Re: [RFC 1/2] Add SN2 Special Memory driver.

From: Robin Holt <holt_at_sgi.com>
Date: 2004-09-10 18:00:29
On Fri, Sep 10, 2004 at 08:35:21AM +0100, Christoph Hellwig wrote:
> On Thu, Sep 09, 2004 at 12:53:39PM -0500, Robin Holt wrote:
> > 
> > Really, this is a 2 part patch and not a 4 part.
> > 
> > Rename the fetchop.h to mspec.h.
> > 
> > Index: linux-2.6/include/asm-ia64/sn/mspec.h
> > ===================================================================
> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ linux-2.6/include/asm-ia64/sn/mspec.h	2004-08-31 12:13:43.000000000 -0500
> > @@ -0,0 +1,85 @@
> > +/*
> > + *
> > + * This file is subject to the terms and conditions of the GNU General Public
> > + * License.  See the file "COPYING" in the main directory of this archive
> > + * for more details.
> > + *
> > + * Copyright (c) 2001-2003 Silicon Graphics, Inc.  All rights reserved.
> > + */
> > +
> > +#ifndef _ASM_IA64_SN_FETCHOP_H
> > +#define _ASM_IA64_SN_FETCHOP_H
> 
> These don't match the filename.

I will fix this.

> 
> > +
> > +#include <linux/config.h>
> > +
> > +#define FETCHOP_BASENAME	"sgi_fetchop"
> > +#define FETCHOP_FULLNAME	"/dev/sgi_fetchop"
> 
> This doesn't belong into a kernel header.

Removed in patch 2.
> 
> > +/*
> > + * Convert a region 6 (kaddr) address to the address of the fetchop variable
> > + */
> > +#define FETCHOP_KADDR_TO_MSPEC_ADDR(kaddr)	TO_MSPEC(kaddr)
> 
> Why this wrapper?

Removed in patch 2.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Sep 10 04:03:38 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:30 EST