Re: [PATCH 1/4] SGI Altix cross partition functionality

From: Dean Nelson <dcn_at_sgi.com>
Date: 2004-08-24 02:50:59
On Wed, Jun 16, 2004 at 05:39:44PM +0100, Christoph Hellwig wrote:
> On Wed, Jun 16, 2004 at 11:33:39AM -0500, Dean Nelson wrote:
> > --- linux.orig/arch/ia64/sn/kernel/setup.c	Thu Jun 10 16:29:44 2004
> > +++ linux/arch/ia64/sn/kernel/setup.c	Thu Jun 10 16:31:55 2004
> > @@ -50,6 +50,7 @@
> >  #include <asm/sn/sn2/shub.h>
> >  
> >  DEFINE_PER_CPU(struct pda_s, pda_percpu);
> > +EXPORT_SYMBOL(per_cpu__pda_percpu);
> 
> Umm, no.  Poking into kernel per-cpu data like the pda from modules sounds
> like a bad idea.  And if you absolutely must use the proper helpers for
> exporting it.

Just an FYI, XPC needs to use the enable_shub_wars_1_1() macro which
accesses pda->shub_1_1_found. So we do need to export per_cpu__pda_percpu.
I've switched EXPORT_SYMBOL() to EXPORT_PER_CPU_SYMBOL() instead.

Dean
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Aug 23 12:56:29 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:29 EST