Re: [PATCH] minor processor.h cleanup

From: Bjorn Helgaas <bjorn.helgaas_at_hp.com>
Date: 2004-04-30 00:38:36
On Wednesday 28 April 2004 10:52 pm, David Mosberger wrote:
> >>>>> On Wed, 28 Apr 2004 10:11:38 -0600, Bjorn Helgaas <bjorn.helgaas@HP.COM> said:
> 
>   Bjorn> Move PSR.ic clear/restore into ia64_itr().
>   Bjorn> Remove ia64_itc(), ia64_ptr(), ia64_set_iva() (unused).
> 
> I'm not sure I consider this a cleanup.  The processor.h
> inlines/macros were meant to map more or less directly to processor
> instructions.  Mucking with psr.ic is quite expensive so it's useful
> to be able to batch several things together and not have to toggle
> psr.ic every time.  But then again, if we never use it that way, I can
> see your point...

I don't feel strongly either way.  The comment "Cannot write to CRx with
PSR.ic=1" preceding the ia64_itr() call just wasn't obvious to me and it
seemed like a good opportunity for someone to screw up when calling
ia64_itr().
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Apr 29 10:44:03 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:25 EST