Re: [PATCH] module relocation code

Hello David,

On Wed, 21 Apr 2004, David Mosberger wrote:

> Yes, the code is probably fine, but I think it could be structured
> better for better.

Do you mean there should be more generic code to handle the same problem
for other relocation types? BTW, do you have any hints as to which types
need to be fixed besides PCREL21B?

Also, you mentioned formatting problems in the patch, but I can't see any.

> BTW: a PLT is also a bit of overkill.  What you're doing is similar to
> what the GNU linker calls "relaxation" (extending the reach of a
> branch), since the gp value is the same for the caller and the callee.

Indeed, but the only benefit I can see is that we could use a smaller plt
entry that does not update gp and simply branches to the target. Only
module .init code is impacted, so I'm not sure it is worth handling it
differently.

Now, I am fairly new to relocations and the like, so maybe I am missing
something.


Best regards,

-- 
Jean-Marc Saffroy - jean-marc.saffroy@ext.bull.net

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html