Re: [PATCH] ISA stubs for ia64

From: Bjorn Helgaas <bjorn.helgaas_at_hp.com>
Date: 2004-04-08 01:09:12
On Tuesday 06 April 2004 5:18 pm, David Mosberger wrote:
> I don't like this patch at all.  The #defines to
> unsupported_isa_dma_interface() turn compile-time errors into
> potential runtime errors.  With a properly abstracted interface, the
> ISA-compatibility-macros should not lead to any code in ISA-free
> systems (and hence there would be no possibility of runtime errors).

True.  I actually started by modifying drivers to use CONFIG_ISA to
determine whether to use ISA interfaces, but (a) that leads to a lot
of changes, most of which I can't test and have the potential to break
other arches, and (b) somebody suggested that ISA is sort of a special
case because it hasn't been converted to the driver model.

But I certainly agree that it would be a lot cleaner.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Apr 7 11:12:17 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:25 EST