Re: [PATCH] ISA stubs for ia64

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2004-04-07 09:18:50
>>>>> On Tue, 6 Apr 2004 16:30:20 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:

  Bjorn> These stubs allow us to build all the old drivers that assume
  Bjorn> ISA is present.  (Many of these support both ISA and PCI
  Bjorn> adapters, so we do actually want them.)

  Bjorn> With this patch and the others I just posted (hw_random,
  Bjorn> simscsi, gen_rtc), we can build allmodconfig on ia64.

I don't like this patch at all.  The #defines to
unsupported_isa_dma_interface() turn compile-time errors into
potential runtime errors.  With a properly abstracted interface, the
ISA-compatibility-macros should not lead to any code in ISA-free
systems (and hence there would be no possibility of runtime errors).

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Apr 6 19:26:08 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:25 EST