Re: Hugetlbpages in very large memory machines.......

From: Hirokazu Takahashi <>
Date: 2004-03-16 13:32:09

> > +   pte = huge_pte_alloc(mm, address);
> > +   set_huge_pte(mm, vma, page, pte, vma->vm_flags & VM_WRITE);
> This looks broken. Another CPU could have raced to the same fault
> and already added an PTE here. You have to handle that.
> (my i386 version originally had the same problem)

Yes, you are true.
In the fault handler, we should use find_lock_page() instead of
find_get_page() to find a hugepage associated with the fault address.
After that pte_none(*pte) should be called again to check whether 
some races has happened.

> > +/*      update_mmu_cache(vma, address, *pte); */
> I have not studied low level IA64 VM in detail, but don't you need
> some kind of TLB flush here?
> -Andi

Thank you,
Hirokazu Takahashi.
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to
More majordomo info at
Received on Mon Mar 15 21:35:14 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:24 EST