Re: [Lse-tech] Re: fix zonelist ordering for NUMA

From: Martin J. Bligh <mbligh_at_aracnet.com>
Date: 2004-02-27 10:54:41
> On Thu, 2004-02-26 at 14:21, Martin J. Bligh wrote:
>> Also, I seem to recall those build_zonelists functions are used for both
>> NUMA and UMA ... now they're getting complex enough that it's probably
>> worth making a specific non-NUMA version, if only for the sanity of
>> 99% of the poor souls trying to work out how a UMA machine lays it out ;-)
>> 
>> It looks like it won't change ordering for existing boxes with single
>> layer flat NUMA topologies (round-robin), but we probably ought to check
>> that carefully ;-)
> 
> More ifdefs just make the code messier.  How about adding a nice comment
> explaining that UMA will fall right through the loop, and giving the
> poor souls a temporary reprieve?

In this case, I disagree - it's better to just have the ifdef.

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Thu Feb 26 18:58:40 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:22 EST