Re: [Lse-tech] fix zonelist ordering for NUMA

From: <j-nomura_at_ce.jp.nec.com>
Date: 2004-02-25 16:02:42
Hi,

> > + 		for (node = 1; node < numnodes; node++)
> > + 			j = build_zonelists_node(SORTED_NODE_DATA(local_node, node), zonelist, j, k);
> 
> Shouldn't that for loop be:
> 	for (node = 0; node < numnodes; node++)
> 		j = ....
> 
> or we'll be leaving a node out of the zonelists, right?

No. The zonelist for the local_node is built before the code above.

The whole code looks like:

> local_node = pgdat->node_id;
> ...
> j = build_zonelists_node(pgdat, zonelist, j, k);
> ...
> for (node = 1; node < numnodes; node++)
>     j = build_zonelists_node(SORTED_NODE_DATA(local_node,node), zonelist, j, k);

Actually, we might be able to clean it up like:

> for (idx = 0; idx < numnodes; idx++)
>     j = build_zonelists_node(SORTED_NODE_DATA(local_node,idx), zonelist, j, k);

Best regards.
--
NOMURA, Jun'ichi <j-nomura@ce.jp.nec.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Feb 25 00:03:06 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:22 EST