Re: [2.6 PATCH] Altix hotplug

From: Greg KH <greg_at_kroah.com>
Date: 2004-02-25 08:38:07
On Tue, Feb 24, 2004 at 01:16:14PM -0600, Pat Gefre wrote:
> On Mon, 23 Feb 2004, Greg KH wrote:
> 
> + On Mon, Feb 23, 2004 at 08:55:14AM -0600, Pat Gefre wrote:
> + > +#define SYSCTL_PCI_UNINITIALIZED	(SYSCTL_PCI_ERROR_BASE - 0)
> + > +    { SYSCTL_PCI_UNINITIALIZED, "module not initialized" },
> + 
> + What are you going to do with this large table of strings?  I see where
> + you copy them to somewhere, but don't see anything beyond that.
> + 
> + Are we missing a huge piece of the puzzle?
> 
> Greg,
> 
> They are used in sysctl_pci_error_lookup(), which is called
> pcibr_slot_pwr(), which is the code to put a device on-line. It all
> traces back to the slot_enable call that is made from the hot plug
> driver (which is not included in this mod).

Ok, as stated before, please post both pieces so we can see if it even
makes sense for you to be splitting things up in this way (you realize
that no other pci hotplug driver needs to do it in this manner, right?)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 24 16:53:24 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:22 EST