Re: [patch] 2.6.2-rc2 Remove compile warnings from timer.o

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2004-02-11 09:29:10
>>>>> On Thu, 5 Feb 2004 17:11:36 +1100, Darren Williams <dsw@gelato.unsw.edu.au> said:

  Darren> This ia a relatively simple patch to remove compile
  Darren> warnings: kernel/timer.c: In function `second_overflow':
  Darren> kernel/timer.c:589: warning: right shift count is negative
  Darren> kernel/timer.c:592: warning: right shift count is negative

  Darren> when CONFIG_IA64_HP_SIM=y.

  Darren> Tested with SIM boots and compile.

  Darren> -#  define HZ	  32
  Darren> +#  define HZ	  96

Doesn't strike me as the correct fix: looking at timex.h, clearly HZ
values as low as 12Hz are supposed to be supported.  Perhaps a better
fix would be to change timer.c to verify that
SHIFT_SCALE<=SHIFT_USEC+SHIFT_HZ before attempting to do the shifting
(via a CPP #if, of course).

Also, I'm a bit reluctant to increase the HZ value for the simulator,
because too large a value will cause the simulated kernel to fail to
make forward progress on slow host machines.

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 10 17:31:41 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:22 EST