Re: salinfo-0.4 patch

From: Ben Woodard <woodard_at_redhat.com>
Date: 2004-01-29 10:32:24
On Wed, 2004-01-28 at 13:50, Keith Owens wrote:
> On 28 Jan 2004 13:22:08 -0800, 
> Ben Woodard <woodard@redhat.com> wrote:
> >Here is a tiny patch for salinfo-0.4. There is a problem with when it
> >deals with multiple errors. The decoded error messages fill up with
> >progressively more white space. 
> 
> That should not occur, the ++indent/--indent lines should be matched.
> Instead of forcing indent back to 0, please find the missing line and
> fix it.  Correct code is better than an arbitrary reset.
> 
> If you have a sample of nested indent that will help track down the
> bug, send it to kaos@sgi.com.
> 
> >While poking around in the iprint function, I also found an error
> >message that looks like it is better suited for stderr rather than
> >stdout so I retargetted it.
> 
> No.  I deliberately used stdout so the error message would appear at
> the end of the truncated file on disk, to tell the viewer that this
> particular file was incomplete.  stderr is useless when salinfo_decode
> is run from init.d.

OK how about this patch. I think I found the missing --indent.

diff -u -r1.1 mca.c
--- mca.c       2004/01/28 23:28:03     1.1
+++ mca.c       2004/01/28 23:28:27
@@ -857,6 +857,7 @@
        }
        if (pcei->valid.oem_data)
                platform_pci_comp_err_print(&pcei->header, p_oem_data);
+       --indent;
 }
  
 /* Format and log the platform specifie error record section data */


-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Jan 28 18:36:49 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:21 EST