Re: [RFC/PATCH, 2/4] readX_check() performance evaluation II

From: Andi Kleen <ak_at_suse.de>
Date: 2004-01-29 07:19:59
On Wed, 28 Jan 2004 21:15:54 +0100
Andi Kleen <ak@suse.de> wrote:

>
> > 
> > Just set a flag aka "may need checking", and let the check be done by the 
> > actual "read_pcix_error()" code.
> 
> Where would you put the flag? 
> 
> Doing it global may give false errors for the wrong device with async MCEs
> and on SMP.
> 
> For putting it into the pci_dev you need to take logs to walk the list.
> If you delay it to a softirq for safely getting the lock it would be set too late.
> 
> Putting it into a different table indexed by pci index would be also racy 
> with hotplug.

... to follow up myself ...

I suppose moving the pci_dev lists to RCU could make the flag in pci-dev work. But it would be still
a bit tricky with preemptive kernels.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Jan 28 15:39:14 2004

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:21 EST