Re: [patch] 2.4.23 fix deadlock in ia64_mca_cmc_int_caller

From: Alex Williamson <alex.williamson_at_hp.com>
Date: 2003-12-08 16:30:00
On Sun, 2003-12-07 at 22:08, Keith Owens wrote:
> smp_call_function() must not be called from interrupt context (can
> deadlock on tasklist_lock).  Use keventd to call smp_call_function().
> 

Keith,

   Looks good to me, only comment I have would be to tack the below
chunk into ia64_mca_late_init().  Anywhere before setting
cmc_polling_enabled to the correct state should prevent a race.  Thanks
for fixing this.

	Alex

> @@ -2411,3 +2429,12 @@ ia64_mca_disable_cpe_polling(char *str)
>  }
>  
>  __setup("disable_cpe_poll", ia64_mca_disable_cpe_polling);
> +
> +static int __init init_mca(void)
> +{
> +	INIT_TQUEUE(&cmc_disable_tq, ia64_mca_cmc_vector_disable_keventd, NULL);
> +	INIT_TQUEUE(&cmc_enable_tq, ia64_mca_cmc_vector_enable_keventd, NULL);
> +        return 0;
> +}
> +
> +module_init(init_mca)


-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Dec 8 00:36:02 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:20 EST