Re: [PATCH] - prof_cpu_mask problems

From: Paul Jackson <pj_at_sgi.com>
Date: 2003-11-20 13:17:03
> It was to silence a warning.

ah - ok - thanks.


> You'll have write your own to replace
> the fix now in -mm if this is what you really want.

I'm doing that now; and un-duplicating about a dozen instances of the
binary->string conversion loops used when reading out masks, and almost
as many string->binary parse_hex_value() routines used when reading in
masks.  There will be a single routine for each, in a new lib file.

Can you tell me, Bill, how it is that having:

  #define HEX_DIGITS (2*sizeof(cpumask_t))

leaves room for the terminating nul-byte?  Seems to me that
a lot of hexnum[] arrays might be one byte short.

One incompatibility with existing code:

    If I proceed along my current path, cpumasks, such as for
    irq or smp_affinity, will no longer be displayed in /proc
    with leading zero padding.

    I expect that this could be a problem ...

Complaints invited.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Nov 19 21:19:17 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:20 EST