Re: [PATCH] fix EFI memory map trimming

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2003-10-21 04:55:39
>>>>> On Mon, 20 Oct 2003 09:54:16 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:

  Bjorn> On Friday 17 October 2003 7:09 pm, David Mosberger wrote:
  >> +			if (check_md->attribute & EFI_MEMORY_WB &&
  >> +			    check_md->phys_addr == first_non_wb_addr)

  >> This needs a pair of parens to avoid a compiler warning, I think.

  Bjorn> gcc-3.3.2 doesn't warn either way, but here's a version with
  Bjorn> the extra parens:

Huh, you're right (neither does gcc-2.96, for example).  My mistake.
Still, I think the code is clearer with parens.

I applied the patch now, thanks.

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Oct 20 14:56:33 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:19 EST