[PATCH 2.4 and 2.6] infinite loop in ia64_mca_wakeup_ipi_wait

From: Luck, Tony <tony.luck_at_intel.com>
Date: 2003-10-14 04:47:04
This bugfix has been hiding inside the MCA TLB patches.

There is an infinite loop in ia64_mca_wakeup_ipi_wait() because
the compiler optimizes away the test at the bottom of the while
loop.  It does this because IA64_MCA_WAKEUP_VECTOR is 0xf0, so
irr_bit is known to be the constant 0x30, a.k.a. 48 in decimal.
So when the compiler looks at the expression:

	while (!(irr & (1 << irr_bit)))

It observes that "1" (an *integer* constant) shifted left by 48
bits is 0, and so the value of "irr" becomes irrelevent.

The fix is to make sure that the compiler treats the "1" as unsigned
long:

--- old/arch/ia64/kernel/mca.c	2003-10-13 11:20:08.885518014 -0700
+++ new/arch/ia64/kernel/mca.c	2003-10-13 11:20:31.427509925 -0700
@@ -828,7 +828,7 @@
 			irr = ia64_getreg(_IA64_REG_CR_IRR3);
 			break;
 		}
-	} while (!(irr & (1 << irr_bit))) ;
+	} while (!(irr & (1UL << irr_bit))) ;
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Oct 13 14:47:26 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:19 EST