Re: [PATCH] Fix IA64 build with separate source and build trees.

From: Peter Chubb <peter_at_chubb.wattle.id.au>
Date: 2003-10-09 11:24:47
>>>>> "Matthew" == Matthew Wilcox <willy@debian.org> writes:

Matthew> On Thu, Oct 09, 2003 at 09:52:12AM +1000, Peter Chubb wrote:
>> Hi David, This patch against 2.6.0-test7 fixes building in a
>> separate output directory.  Without it, offsets.h isn't built, and
>> the check-gas and toolchain-flags sscripts aren't found.

Matthew> I'm more curious than anything ...

>> +arch/$(ARCH)/kernel/asm-offsets.s: include/asm
>> include/linux/version.h
Matthew> [...]
>> -arch/ia64/kernel/asm-offsets.s: include/asm-ia64/.offsets.h.stamp
>> +arch/ia64/kernel/asm-offsets.s:
>> include/asm-$(ARCH)/.offsets.h.stamp

Matthew> What's the advantage to using $(ARCH) here?  Since this is in
Matthew> an arch directory, we already know our $ARCH.  And if we are
Matthew> going to use it, shouldn't it be used everywhere?


Main advantage is it makes this bit of code almost identical between
architectures, so that when someone updates it a simple grep will find
it everywhere.  And yes, it should be ${ARCH} everywhere htat there's
identical code between architectures (which means everywhere, for
simplicity as to know when to use what)

Peter C
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Oct 8 21:25:23 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:19 EST