Re: Why does salinfo_log_read_cpu use kmalloc?

From: Bjorn Helgaas <bjorn.helgaas_at_hp.com>
Date: 2003-10-09 01:55:44
On Wednesday 08 October 2003 1:08 am, Keith Owens wrote:
> Why does arch/ia64/kernel/salinfo.c::salinfo_log_read_cpu() use
> kmalloc() for the log buffer?  The code is running virtual with
> interrupts enabled, SAL_GET_STATE_INFO has no special requirements for
> the buffer attributes, so why not use vmalloc()?

It's usually called via smp_call_function_single(), which uses
an IPI to make it happen on another processor.  I thought
this meant the function got called with interrupts disabled,
but I could be wrong.

And yes, I do need to push this to 2.6.  It's on my to-do list.

Bjorn

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Oct 8 12:00:48 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:19 EST