Re: [PATCH] do_gettimeofday() fails to compensate for lost ticks

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2003-09-25 04:29:18
>>>>> On Wed, 24 Sep 2003 12:17:41 -0600, Khalid Aziz <khalid_aziz@hp.com> said:

  Khalid> So it would seem. What would then explain clock going
  Khalid> backwards? Here is what I see when the test fails:

  Khalid> tpget=1037128357,995121000, tpset=1037128358,0

  Khalid> where tpget is what was returned by gettimeofday() and tpset
  Khalid> is what was set by settimeofday(). Clock seems to have moved
  Khalid> back by 4.879 msec.

Not sure off-hand and I haven't looked at the 2.4 code-base in a
while, but aren't we double-compensating in do_settimeofday()?  There,
we have:

		tv->tv_usec -= gettimeoffset();
		tv->tv_usec -= (jiffies - wall_jiffies) * (1000000 / HZ);

Perhaps the second line just needs to go?

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Sep 24 14:29:39 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:17 EST