Re: [PATCH] more discontig fun

From: Jesse Barnes <jbarnes_at_sgi.com>
Date: 2003-09-09 04:31:27
On Mon, Aug 04, 2003 at 04:27:15PM -0700, David Mosberger wrote:
> >>>>> On Thu, 31 Jul 2003 13:28:57 -0700, jbarnes@sgi.com (Jesse Barnes) said:
> 
> 
>   Jesse> Or would you like to see it cleaned up in some other way?
> 
> I'd like to see it done without changing the interface to efi_memmap_walk().

Rather than calling efi_memmap_walk(filter_rsvd_memory, ...), do you
think it would be ok to move the call into the leaf functions?  E.g.
count_pages would do a if(rsvd_memory(start, end)) return; instead of
getting called from filter_rsvd_memory()?  That would make it easier to
understand and also make it easier to pass the args around.

But maybe a more aggressive cleanup is called for?

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Sep 8 14:42:20 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:17 EST