RE: [PATCH] efivars update

From: Tolentino, Matthew E <matthew.e.tolentino_at_intel.com>
Date: 2003-08-30 10:16:48
Matt,

> Move the unlock up above the status test, else you return while
> holding the lock on failure.

Ouch. Thanks...

> level on printk please.

Fixed.

> Might as well just force the deletion by setting Attributes=0 or
> DataSize=0 or both.  Less chance for userspace error.

Good idea.
 
> Please kill this chunk.  I shouldn't have had it there in the first 
> place. :-)
> 
> Looks great to me!  Thanks again.

Sure thing.  Updated patch attached....

matt

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Received on Fri Aug 29 20:18:34 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:17 EST