>>>>> On Tue, 26 Aug 2003 17:51:15 -0400, Will Cohen <wcohen@redhat.com> said: Will> I have revised the patch based on the comments below: 1) use Will> ip instead of eip 2) multiply ri by 4, to get more compact Will> histograms Hmmh, I'm not sure I like this patch better. Like I mentioned in the earlier mail, it does make sense to encode the slot number in bits 0 and 1 for instruction_pointer(). That is the canonical representation used by IA-64 Linux (and ELF, gdb, etc.). The traditional histogram is a special case, because there it is more useful to get the slot number bits close to the bundle-address bits, so I think we should special-case this in ia64_do_profile() instead. Perhaps something along the lines of: ip = instruction_pointer(regs); /* for histogram, encode slot bits in address bits 2 and 3: */ slot = ip & 3; ip = (ip & ~3UL) + 4*slot; --david - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Tue Aug 26 18:35:32 2003
This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:17 EST