Re: [PATCH] Fix prologue directives for sys_clone() and sys_clone2()]

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2003-08-16 10:43:44
>>>>> On Fri, 15 Aug 2003 17:07:41 -0700, John Byrne <john.l.byrne@hp.com> said:

  John> To my limited understanding, the GRSAVE portions of the .prologue
  John> directives for sys_clone() and sys_clone2() are incorrect. This patch, 
  John> against 2.6.0-test3, fixes them.

Thanks, I applied the patch.

  John> I also wonder whether the the continued usage of the 2
  John> argument form of clone() in kernel_thread() should be
  John> considered "bad form". Admittedly, the other arguments are
  John> don't-care as long as the various CLONE_ flags (which
  John> kernel_thread() does not mask off) are not set , but it just
  John> feels wrong. I guess I wouldn't be a programmer if I didn't
  John> like to pick nits.

clone() is a strict subset of clone2(), so some day we may want to
remove the former.

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Aug 15 20:43:57 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:16 EST