Re: [PATCH] sn2 module (& other misc.) fixes

From: Christoph Hellwig <hch_at_infradead.org>
Date: 2003-08-05 07:54:23
On Mon, Aug 04, 2003 at 02:14:04PM -0700, Jesse Barnes wrote:
>  nasid_t master_baseio_nasid = INVALID_NASID;	/* This is the master base I/O nasid */
> +EXPORT_SYMBOL(master_nasid);

why is this exported?

>  int num_base_io_scsi_ctlr = 2; /* used by syssgi */
>  vertex_hdl_t		base_io_scsi_ctlr_vhdl[NUM_BASE_IO_SCSI_CTLR];
> +EXPORT_SYMBOL(base_io_scsi_ctlr_vhdl);

Why do you want this export.  Or rather why does this tasteless stuff
exist at all?  (And the comment looks wrong, too..)

>  partid_t sn_partid = -1;
> +EXPORT_SYMBOL(sn_partid);
> +
>  char sn_system_serial_number_string[128];
>  u64 sn_partition_serial_number;
> +EXPORT_SYMBOL(sn_system_serial_number_string);
> +EXPORT_SYMBOL(sn_partition_serial_number);
>  
>  short physical_node_map[MAX_PHYSNODE_ID];
> +EXPORT_SYMBOL(physical_node_map);

Again, what is all this for?

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Aug 4 17:55:17 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:16 EST