Re: [PATCH] New CMC/CPE polling

From: Alex Williamson <alex_williamson_at_hp.com>
Date: 2003-08-05 04:49:24
"Luck, Tony" wrote:
> 
> I think that there are some race conditions around the setting/clearing
> of cmc_polling_enabled.
> 

Tony,

   You might be right on the clearing side, I think moving it down
a couple lines and disabling local interrupts would eliminate the
potential hole though.  Something like this:

ia64_mca_cmc_int_caller(...)
{
...
    smp_call_function(ia64_mca_cmc_vector_enable, NULL, 1, 0);
    local_irq_disable();
    ia64_mca_cmc_vector_enable(NULL);
    cmc_polling_enabled = 0;
...

   Does that address the race you were looking at?  I don't see one
on the setting end, could you be more specific?  The spinlock feels
like it does the trick to me.  Thanks for the comments,

	Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Mon Aug 4 14:49:50 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:16 EST