[Linux-ia64] [patch] 2.4.21-rc1 Close rmmod race on ia64

From: Keith Owens <kaos_at_sgi.com>
Date: 2003-05-13 16:43:28
ia64 is not taking the spinlock that closes the race between module
removal and traversal of exception tables.  It can result in oops when
one cpu takes an exception while another is unloading a module.

Other architectures take this lock.  The patch is almost a cut and
paste from i386, plus it removes a dead variable.

diff -urp 2.4.21-rc1-ia64.orig/arch/ia64/mm/extable.c 2.4.21-rc1-ia64/arch/ia64/mm/extable.c
--- 2.4.21-rc1-ia64.orig/arch/ia64/mm/extable.c	Sat Aug  3 11:07:44 2002
+++ 2.4.21-rc1-ia64/arch/ia64/mm/extable.c	Tue May 13 16:37:30 2003
@@ -38,6 +38,8 @@ search_one_table (const struct exception
 register unsigned long main_gp __asm__("gp");
 #endif
 
+extern spinlock_t modlist_lock;
+
 struct exception_fixup
 search_exception_table (unsigned long addr)
 {
@@ -51,10 +53,11 @@ search_exception_table (unsigned long ad
 		fix.cont = entry->cont + main_gp;
 	return fix;
 #else
-	struct archdata *archdata;
+	unsigned long flags;
 	struct module *mp;
 
 	/* The kernel is the last "module" -- no need to treat it special. */
+	spin_lock_irqsave(&modlist_lock, flags);
 	for (mp = module_list; mp; mp = mp->next) {
 		if (!mp->ex_table_start)
 			continue;
@@ -65,9 +68,10 @@ search_exception_table (unsigned long ad
 					 addr, (unsigned long) archdata->gp);
 		if (entry) {
 			fix.cont = entry->cont + (unsigned long) archdata->gp;
-			return fix;
+			break;
 		}
 	}
+	spin_unlock_irqrestore(&modlist_lock, flags);
 #endif
 	return fix;
 }
Received on Mon May 12 23:43:39 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:14 EST