RE: [Linux-ia64] High fpu register corruption

From: Mallick, Asit K <asit.k.mallick_at_intel.com>
Date: 2003-05-09 02:33:55
Andreas,

The high FP save and restore in the context switch makes the assumption that user will not be modifying the psr.mfh and it will be only updated by the hardware. Without this assumption we can not optimize the FP save/restore for SMP systems (this patch will not cover all cases). If application wants the current high fpu state to be preserved then it should will not be able to modify the psr.mfh.

What kind of applications are trying to modify the mfh?

Thanks,
Asit
 

> -----Original Message-----
> From: Andreas Schwab [mailto:schwab@suse.de]
> Sent: Thursday, May 08, 2003 7:16 AM
> To: linux-ia64@linuxia64.org
> Cc: Chris Mason
> Subject: [Linux-ia64] High fpu register corruption
> 
> When a process clears the psr.mfh bit after using the high fpu registers
> and then starts using them again it can corrupt the fpu state of another
> process.  In order for this to happen there must be some context switches
> inbetween (thanks to Chris Mason for tracking this down):
> 
> Processes start with psr.dfh=1, IA64_THREAD_FPH_VALID not set
> 
> proc A                               proc B
> ------                               ------
> use fph reg
> -> trap, mfh=1, dfh=0
> -> fpu_owner = proc A
> clear mfh (rum)
> 
> context switch
> -> no registers saved
> -> IA64_THREAD_FPH_VALID not set
> 
>                                      start running
>                                      use fph reg
>                                      -> trap, mfh=1, dfh=0
>                                      -> fpu_owner = proc B
> 
>                                      context switch
>                                      -> save registers, mfh=0
>                                      -> set IA64_THREAD_FPH_VALID
> 
> continue running
> -> IA64_THREAD_FPH_VALID not set
> -> dfh not modified
> 
> modify fph reg
> -> no trap
> -> fpu_owner still proc B
> clear mfh (rum)
> 
> context switch
> 
>                                      continue running
>                                      -> fpu_owner still proc B
>                                      -> dfh=0, mfh=0
> 
> At this point proc B uses the fph registers that were modified by proc A.
> The problem is that dfh was not set for proc A although
> IA64_THREAD_FPH_VALID wasn't set and proc A is not the fpu owner.  This
> patch fixes the problem:
> 
> --- linux-2.4/include/asm-ia64/system.h.~1~	2003-05-07
> 15:44:44.000000000 +0200
> +++ linux-2.4/include/asm-ia64/system.h	2003-05-07 15:31:47.000000000
> +0200
> @@ -281,7 +281,8 @@ extern void ia64_load_extra (struct task
>  		} else {						\
>  			ia64_psr(ia64_task_regs(next))->dfh = 1;	\
>  		}							\
> -	}								\
> +	} else if (ia64_get_fpu_owner() != next)			\
> +		ia64_psr(ia64_task_regs(next))->dfh = 1;		\
>  	__switch_to(prev,next,last);					\
>    } while (0)
>  #else
> 
> 
> Andreas.
> 
> --
> Andreas Schwab, SuSE Labs, schwab@suse.de
> SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
> Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
> 
> _______________________________________________
> Linux-IA64 mailing list
> Linux-IA64@linuxia64.org
> http://lists.linuxia64.org/lists/listinfo/linux-ia64
Received on Thu May 08 09:35:40 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:14 EST