Re: [Linux-ia64] [patch] 2.4.20-021210 misaligned sal error record

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2003-03-05 11:45:05
>>>>> On Wed, 05 Mar 2003 11:33:33 +1100, Keith Owens <kaos@sgi.com> said:

  Keith> Linus recommends static inline instead of #define unless
  Keith> there is no choice.  static inline does type checking,
  Keith> #define does not.

That's a good principle, but doesn't really apply here.  You do
get type-checking:

#define SAL_LPI_PSI_INFO(l)				\
	sal_log_processor_info_t *_l = (l);

and for this type of work-around-C-limitation helper routine, I think
a capitalized macro actually results in more readable code.  It's a
matter of taste, of course.

	--david
Received on Tue Mar 04 16:46:39 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:12 EST