Re: [Linux-ia64] [Patch] Fix in process.c

From: David Mosberger <davidm_at_napali.hpl.hp.com>
Date: 2003-01-18 12:53:04
This one I REALLY don't like:

>>>>> On Fri, 17 Jan 2003 17:43:44 -0800, "Siddha, Suresh B" <suresh.b.siddha@intel.com> said:

  Suresh> - extern char ia64_ret_from_clone;
  Suresh> + extern void  ia64_ret_from_clone(void);

  Suresh> - child_stack->b0 = (unsigned long) &ia64_ret_from_clone;
  Suresh> + child_stack->b0 = ((unsigned long *) &ia64_ret_from_clone)[0];

Why materialize a function pointer for ABSOLUTELY no reason?
Furthermore, &FUNC can be used as a static initializer, whereas
((long*)&FUNC)[0] cannot.

	--david
Received on Fri Jan 17 17:54:45 2003

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:11 EST