[Linux-ia64] Re: Two PCI Hotplug Drivers for 2.5

From: Greg KH <greg_at_kroah.com>
Date: 2002-10-23 09:49:13
On Tue, Oct 22, 2002 at 04:28:14PM -0700, Lee, Jung-Ik wrote:
> 
> Hi Greg,
> 
> Please find the attached two PCI hotplug drivers for 2.5.
> 
>  intcphp: New Intel's PHP driver for CPQ or equivalent Intel
> 	    controllers for IA32/IA64, ACPI/legacy platforms.
> 	    This driver is needed for IA64 servers (Lion,
> 	    Tiger, etc), and has been verified on 2.5.39
>  acpiphp: ACPI based PHP driver updated to support CAL(*).
> 	    ACPI based ctrl/slot operations are abstracted to
> 	    CAL module. This has been verified on 2.5.39 and
> 	    Feature/functionality remain the same. 
> 	    Patch against Tak's 2.5.39 patch is included.
> 
> 
> (*) CAL is a Controller Abstraction Layer that we came up to provide a
> convenient and uniform interface to different types of hotplug controllers.
> CAL abstracts details of individual HP controller/slot operations and also
> provides flexibility of binding different CAL modules to single php driver
> core. Both intcphp driver and acpiphp driver support CAL interface.

Ah, something like this is nice to have, but you duplicated a _lot_ of
code in getting here.  A patch moving some of the common Compaq code to
the pci_hotplug.o module, which would enable a lot of the compaq and
acpi driver code to be removed would be greatly appreciated.

> The reason why we separated slot/controller operations(event management) as
> CAL is to make most of Common hotplug driver components not only for Hotplug
> PCI driver but also for Hotplug-Everything, required for Atlas project, and
> other server platforms.
> For Hotplug-everything - Hotplug-PCI, IO-Node, and memory, etc.-, ACPI based
> Resource Management and Event management are key common components.
> 
> To design an ACPI based PCI HP driver, we need a combination of the two
> common Hotplug-Everything components and PCI HP driver core.
> 	1. ACPI based PHPRM(Resource Management/configuration)
> 	2. Event Management(ACPI based or OEM ctrl based CAL)
> 	3. PHP driver core: usage model of PHP
> 
> For Hotplug-Others, #1, and #2 should be the same and #3 will be replaced
> with Hotplug-Other driver core.
> 
> This release is the first step to achieve the goal of the Common HotPlug
> architecture while minimizing affects on existing PHP driver features and
> functionalities. Current status of the drivers is: 
>   + Both conform to CAL.

A layer you came up with?  I would hope this driver would match it :)

>   + hotplug_ops routines are identical.

We have common hotplug operations right now.  What's wrong with those?
I'm not going to have some API that looks the same for PCI cards and
memory DIMMS, that's just dumb.  They are different things, and do
different things, don't try to merge them together.

>   + Functionality of Resource managements(PHPRM) are the
>     same and soon will share phprm_acpi.
>   + Both will use common php core.

Hm, and also you can now plug in closed source hotplug drivers, as you
went around the existing EXPORT_SYMBOL_GPL() symbols.  I've told you
about this _many_ times in the past and will never accept such a patch,
as you have said this is your end goal.

> The ultimate difference between acpiphp driver and intcphp driver,
> therefore, will be the CAL implementation only. I.e., acpiphp will use ACPI
> based event management for controller/slot operations thru CAL interface,
> while intcphp can use either it's own HPC controller based CAL or acpiphp's
> ACPI based event management CAL.
> 
> 
> We've tested two drivers with 2.5.39/IA64. This should also apply to 2.5.41
> and later. 2.4 backport will be available later as needed.
> Please apply.

Because of the above comments, no, I will not.  What I will accept would
be:
	- move the common code that you have already identified into the
	  pci_hotplug core.  That will enable the Compaq and ACPI
	  drivers to remove a lot of code (and hopefully the IBM driver,
	  but don't worry about that if it doesn't look obvious.)
	- stick with the existing pci_hotplug API for hotplug PCI
	  drivers.  If you need something different from what is
	  currently there, please let me know.  But do NOT try to go
	  around the EXPORT_SYMBOL_GPL functions by providing your own
	  shim layer, that's not acceptable.
	- please remove all typedefs from the code.
	- remove all LINUX_VERSION checks as they are necessary for code
	  that is in the main kernel tree.

thanks,

greg k-h
Received on Tue Oct 22 16:50:34 2002

This archive was generated by hypermail 2.1.8 : 2005-08-02 09:20:10 EST