Re: [PATCH 1/2] Add `struct object_hash`

Hi,

On Sun, 18 Feb 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Using object_hash, you can store interesting information about
> > objects in a private hash map. This makes up for the lack of a
> > `util` member of `struct object`.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > 	We should have done that earlier. Now, git.git already
> > 	contains two specialised versions of an object hash map:
> > 	obj_hash and refs_hash.
> >
> > 	obj_hash is not really a hash map, but rather a hash set,
> > 	but there is no excuse for refs_hash having its own little
> > 	private implementation nobody else can reuse.
> 
> Ok, having now looked at it more, I can say:
> 
>  - I hate it.
> 
> I dislike it intensely, because it's so _close_ to being usable.

Seeing your patch I know why. I could not think of a sane method to 
condense the two pointers into one. Thank you for pointing out one.

I have not had a close look at it, that will have to wait for tomorrow.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html