Re: [PATCH 2/2] Teach name-rev to identify revisions containing a certain blob

From: Junio C Hamano <junkio@cox.net>
Date: 2007-02-18 05:30:50
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> +static struct object_hash file_trees = { 0, 0, NULL };
> +static struct object_array file_commits = { 0, 0, NULL };

These don't look good for two reasons: (1) you could leave BSS
to do the 0 initialization; (2) you need to change this if you
need to change the shape of "struct object_hash" later.

> +#define CONTAINS_FILE (1u<<10)

I am partly at fault, but I think we should have a consolidated
bit assignment policy in place before introducing new users of
object flags.  Some older code says in their comments that
revision.h reserves lower 8 bits while others say 16.  I offhand
know who is correct X-<.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sun Feb 18 05:31:05 2007

This archive was generated by hypermail 2.1.8 : 2007-02-18 05:37:36 EST