On Sat, 17 Feb 2007, Shawn O. Pearce wrote: > Martin Waitz <tali@admingilde.org> wrote: > > arg, this patch is completely broken. > > I tested it by setting the macro via the command line and the > > = is still left in there. And __GLIBC__ is not yet defined at this > > point. > > > > However, we need to set _FILE_OFFSET_BITS for glibc somehow. > > What is the best way to do so? > > I think the only way to do with this is to have the Makefile detect > if -D_FILE_OFFSET_BITS=64 is required to be added to CFLAGS based on > some rule (e.g. uname output?), then add that to CFLAGS when needed. Why not simply defining _FILE_OFFSET_BITS=64 unconditionally? It certainly won't cause GIT to explode if compiled against something else than glibc. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Sun Feb 18 00:32:29 2007
This archive was generated by hypermail 2.1.8 : 2007-02-18 00:34:22 EST