Re: [PATCH] pager: use an environment variable for pager_in_use

From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Date: 2007-02-17 06:43:30
Johannes Schindelin wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>>> +int pager_in_use = getenv("GIT_PAGER_IN_USE");
>> test.c:3: error: initializer element is not constant
> Sorry.
> 
> Still, it feels wrong to use two system calls when you need none.

getenv() is usually no system call, but processed in userland.

However, I also always get the feeling that using environment variables within one process to communicate state seems wrong, but many old unix tools do it this way.

cheers
  simon

-- 
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Received on Sat Feb 17 06:52:10 2007

This archive was generated by hypermail 2.1.8 : 2007-02-17 06:57:21 EST