Re: git-svn test suite failures due to Subversion race

From: Eric Wong <normalperson@yhbt.net>
Date: 2007-02-13 14:21:37
Michael Spang <mcspang@gmail.com> wrote:
> I've prepared a somewhat cleaner patch that solves the problem without
> using sleep. It increases the modification time by one second
> immediately prior to each commit. I added calls everywhere I think the
> problem could potentially occur.
> 
> I've had no failures with the patch (without it, they are quite frequent).

Thanks for the patch.  Just one portability nit below, otherwise:
Acked-by: Eric Wong <normalperson@yhbt.net>

> +poke() {
> +	touch -r "$1" -d +1sec "$1"
> +}

I'm not sure that -d is portable.  However,

  perl -e '@x = stat($ARGV[0]); utime($x[8], $x[9] + 1, $ARGV[0])' "$1"

should work on any platform git-svn runs on.

-- 
Eric Wong
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 13 15:05:50 2007

This archive was generated by hypermail 2.1.8 : 2007-02-13 15:22:11 EST