Re: [PATCH] Read cvsimport options from repo-config

From: Junio C Hamano <junkio@cox.net>
Date: 2007-02-06 15:26:17
I find what your patch does quite sensible, although the
split(/ *(?!:)/) magic might be a bit hard to read for the
uninitiated.

> +		my $arg = 'git-repo-config';
> +		$arg .= ' --bool' if ($o !~ /:$/);
> +
> +        chomp(my $tmp = `$arg --get cvsimport.$key`);
> +		if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {

Can this =~ / --bool / ever match (note the SP after 'l')?

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Feb 06 15:26:44 2007

This archive was generated by hypermail 2.1.8 : 2007-02-06 15:28:30 EST