Re: [PATCH 2/2] Flag and skip over packfiles known to be invalid.

From: Junio C Hamano <junkio@cox.net>
Date: 2007-02-02 19:34:17
"Shawn O. Pearce" <spearce@spearce.org> writes:

> If we've already looked at a packfile and determined it isn't
> valid/usable as a pack, we shouldn't try to use it again in
> the future either.  This avoids multiple error messages from
> the same packfile.

I haven't looked your patch very closely, but two successive
"git-repack -a -d" would produce the packfile under the same
name, but with different parameters (--window or --depth), the
old .idx and new .pack may not match.

Can this be possible (time flows from top to bottom):

	git-repack -a -d		somebody else

	produces a new .pack/.idx

        mv new .pack to objects/pack

					mmap .idx (old)
					finds .pack does not match

	mv new .idx to objects/pack
	
Is this something we care about?

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Feb 02 19:34:57 2007

This archive was generated by hypermail 2.1.8 : 2007-02-02 19:36:47 EST