Re: [PATCH] contrib/emacs/vc-git.el: support vc-version-other-window

From: Alexandre Julliard <julliard@winehq.org>
Date: 2007-01-26 21:57:50
Sam Vilain <sam.vilain@catalyst.net.nz> writes:

> Currently, the vc-git-checkout function uses `git checkout' to fetch a
> file from the git repository to the working copy.  However, it is
> completely ignoring the input argument that specifies the destination
> file.  `git-checkout' does not support specifying this, so we have to
> use `git-cat-file', capture the output in a buffer and then save it.

This looks good, though the code can be made simpler by using
with-temp-file to create the file. Also you need to avoid charset
conversions when reading and writing, and you should use ls-files -z
to avoid problems with strange file names.

I'd suggest something like this:
Received on Fri Jan 26 21:58:12 2007

This archive was generated by hypermail 2.1.8 : 2007-01-26 21:59:53 EST