Re: [PATCH 3/3] Use /dev/null for update hook stdin.

From: Junio C Hamano <junkio@cox.net>
Date: 2006-12-31 17:03:34
"Shawn O. Pearce" <spearce@spearce.org> writes:

> Currently the update hook invoked by receive-pack has its stdin
> connected to the pushing client.  The hook shouldn't attempt to
> read from this stream, and doing so may consume data that was
> meant for receive-pack.  Instead we should give the update hook
> /dev/null as its stdin, ensuring that it always receives EOF and
> doesn't disrupt the protocol if it attempts to read any data.

Both 2 and 3 look sane, but can we have a few new tests too?

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Sun Dec 31 17:05:22 2006

This archive was generated by hypermail 2.1.8 : 2006-12-31 17:06:47 EST