Re: [PATCH/RFC] Documentation: Two more git-rebase --onto examples

On Sun, 5 Nov 2006 11:22:17 +0100, Jakub Narebski wrote:
> I found original example somewhat artifical, but after thinking on that
> I guess that the need for rebase onto master~1 might happen when the last
> commit in master is for example to be amended or rebased.

It is quite artificial in presentation at least. There's no motivating
explanation of what is being attempted just before-and-after diagrams
along with a command that achieves the result. That presentation makes
it very hard to learn how to usefully use the command from the
description.

> > This looks the same as the original example for --onto; I would
> > either drop it or replace it something of different flavor.
>
> This example is from latest post by Andy Parkins, which asked how to
> do that. But I find your example as being better, because it shows
> even more power of core git history manipulation.

I think Jakub's explanations do a much better job of explaining
something someone might actually want to do and then showing how to do
it. So if there's redundancy I'd vote for dropping the old stuff.

Meanwhile, while we're talking about git-rebase documentation, the
recent posts about the:

	git rebase --onto <foo> <upstream> <branch>

form take advantage of the fact that this command also changes the
current branch to <branch>. I think that's quite surprising behavior,
(though useful in the example that was given). It's perhaps out of
line with the scope of git-rebase but it should at least be
documented. I think that will need some specific mention before the
examples.

-Carl

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html