Junio C Hamano wrote: > Jakub Narebski <jnareb@gmail.com> writes: > >> ... First, it did that incompletely: it did not add "blob" >> link for added files, and added block used mixture of tabs and spaces >> for align. Second, in "difftree" view the "blob" link is not the most >> interesting, *contrary* to "blob"/"tree" link in "tree" view, so it >> should be enough to have hidden link in the form of file name entry. > > I think these "blob" links are good thing to have, and if you > think the earlier work was incomplete and know some cases are > not covered I think it would be better to help completing it > rather than reverting. > > I do not understand why you feel "blob" is not the most > interesting. Often, when it is not obvious if a patch is > correct only with the context, it is useful to view the whole > postimage after applying the patch, and the "blob" link helps > that. O.K. I'll choose the "add blob links where there are none in difftree view" approach in cleaned up and resend series. I'll wait a while (a day or two) for further comments before redoing the series. P.S. Remove empty patches might produce incorrect HTML (one of <div> is not closed). I'll correct it on resend. -- Jakub Narebski Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Fri Nov 03 22:01:31 2006
This archive was generated by hypermail 2.1.8 : 2006-11-03 22:03:20 EST