Re: [PATCH] Continue traversal when rev-list --unpacked finds a packed commit.

From: Junio C Hamano <junkio@cox.net>
Date: 2006-10-31 12:47:14
Jan Harkes <jaharkes@cs.cmu.edu> writes:

> When getting the list of all unpacked objects by walking the commit history,
> we would stop traversal whenever we hit a packed commit. However the fact
> that we found a packed commit does not guarantee that all previous commits
> are also packed. As a result the commit walkers did not show all reachable
> unpacked objects.
>
> Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>

Thanks.

With this, I think revs->unpacked should not mean "limited", so
I suspect this is also needed, no?

diff --git a/revision.c b/revision.c
index 93f2513..2d7cad9 100644
--- a/revision.c
+++ b/revision.c
@@ -1010,7 +1010,7 @@ int setup_revisions(int argc, const char
 		add_pending_object(revs, object, def);
 	}
 
-	if (revs->topo_order || revs->unpacked)
+	if (revs->topo_order)
 		revs->limited = 1;
 
 	if (revs->prune_data) {



-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Oct 31 12:48:37 2006

This archive was generated by hypermail 2.1.8 : 2006-10-31 12:49:33 EST