Re: [PATCH] Checking for "diff.color." should come before "diff.color"

From: Andy Parkins <andyparkins@gmail.com>
Date: 2006-10-24 07:03:40
On Monday 2006, October 23 21:29, Junio C Hamano wrote:
> Andy Parkins <andyparkins@gmail.com> writes:
> > In git_diff_ui_config() the strncmp() for "diff.color" would have matched
> > for "diff.color.", so "diff.color." configs would never be processed.
>
> A test case that demonstrates the breakage without the patch
> would be nice. Could you come up with a two-patch series that
> is:

No need.  Jeff King already caught the fact that my patch is unnecessary.  I 
withdraw it.

Sorry to keep bothering you all with these non-entity patches.  I really am 
only trying to help :-)


Andy

-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Received on Tue Oct 24 07:06:21 2006

This archive was generated by hypermail 2.1.8 : 2006-10-24 07:07:50 EST