Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph

From: A Large Angry SCM <gitzilla@gmail.com>
Date: 2006-10-13 08:20:09
apodtele wrote:
> On 10/12/06, Martin Waitz <tali@admingilde.org> wrote:
>> On Thu, Oct 12, 2006 at 03:37:17PM -0400, apodtele wrote:
>> > Instead of conditionally scaling the stat graph for large changes,
>> > always scale it asymptotically: small changes shall appear without any
>> > distortions.
>>
>> very nice idea!
>>
>> > +     return it * width / (it + width) + 1;
>>
>> but wouldn't this formula result in at least 1, even for a 0 change?
>> Perhaps we'd have to special case an input of 0?
[...]
> +    if (it)
> +        return it * width / (it + width) + 1;
> +    else
> +        return 0;

No conditional needed:

	return it * width / (it + width - 1)
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Oct 13 08:21:07 2006

This archive was generated by hypermail 2.1.8 : 2006-10-13 08:25:29 EST