Jakub Narebski <jnareb@gmail.com> writes: > Martin Waitz wrote: > >> + 'pathinfo' => { >> + 'override' => 0, >> + 'default' => [1]}, > > You should add failsafe to gitweb_check_feature for when 'sub' is not set; > for example when somebody sets $feature{'pathinfo'}{'override'} to 1. Yes, I noticed this last night while playing with it. We would at least need a big warning that says this should not be made overridable (which does not make any sense anyway). Setting 'sub' to a failsafe one that only returns what is in the default without looking at individual repository would be the cleanest, I think. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Wed Oct 04 03:39:29 2006
This archive was generated by hypermail 2.1.8 : 2006-10-04 03:40:48 EST