Luben Tuikov wrote: > --- Junio C Hamano <junkio@cox.net> wrote: >> >> Ouch, that was a sloppy planning and coding, and sloppier >> reviewing. Sorry. >> >> What is the right quoting there? Just quoting double-quotes? > > I'm not sure. What undesired character could we have in $filename > of a snapshot? The commit ab41dfbfd4f message gives this > justification: "Just in case filename contains end of line character." > > It looks like $filename is constructed by well defined strings: > basename($project), $hash and $suffix all of which should be ok. > > I'd say we don't need quotemeta for $filename of snapshot. But we do need quoting for blob_plain and perhaps blobdiff_plain views, although not quotemeta, but perhaps the reverse of unescape, i.e. quote '"', EOLN (end of line) and perhaps also TAB. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htmlReceived on Mon Oct 02 10:28:27 2006
This archive was generated by hypermail 2.1.8 : 2006-10-02 10:29:12 EST