Re: gitweb: using quotemeta

From: Junio C Hamano <junkio@cox.net>
Date: 2006-09-29 09:18:28
Luben Tuikov <ltuikov@yahoo.com> writes:

> Commit ab41dfbfd4f3f9fedac71550027e9813b11abe3d introduces
> the use of quotemeta to quote the $filename of the snapshot.
> The commit message explains:
>
>     Just in case filename contains end of line character.
>
> But quotemeta quotes any characters not matching /A-Za-z_0-9/.
> Which means that we get strings like this:
>     
>     linux\-2\.6\.git\-5c2d97cb31fb77981797fec46230ca005b865799\.tar\.gz
>
> Is this the desired behavior?  FWIW, the backslash character
> is not part of of the name, but ended up when the snapshot was written
> to the filesystem.

Ouch, that was a sloppy planning and coding, and sloppier
reviewing.  Sorry.

What is the right quoting there?  Just quoting double-quotes?



-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Fri Sep 29 09:20:08 2006

This archive was generated by hypermail 2.1.8 : 2006-09-29 09:20:58 EST