Re: [PATCH] gitk: Fix nextfile() and add prevfile()

From: Paul Mackerras <paulus@samba.org>
Date: 2006-09-27 10:15:45
OGAWA Hirofumi writes:

> The current nextfile() jumps to last hunk, but I think this is not
> intention, probably, it's forgetting to add "break;". And this
> patch also adds prevfile(), it jumps to previous hunk.

I think your prevfile isn't quite right - I don't think it will do the
right thing if $loc is past the last entry in $difffilestart.  Don't
you want the "$ctext yview $prev" after the loop?

Paul.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Wed Sep 27 10:16:07 2006

This archive was generated by hypermail 2.1.8 : 2006-09-27 10:17:28 EST