Re: [PATCH 5/5] gitweb: Quote filename in HTTP Content-Disposition: header

From: Jakub Narebski <jnareb@gmail.com>
Date: 2006-09-26 17:51:31
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Finish work started by a2f3db2f5de2a3667b0e038aa65e3e097e642e7d commit
>> (although not documented in commit message) of quoting using quotemeta
>> the filename in HTTP -content_disposition header.  Uniquify output.
>>
>> Just in case filename contains end of line character.
> 
> What do you mean by "uniquify output"?

It means alsways use 'inline; filename="' . (quotemeta <whatever>) . '"',
and not sometimes qq(...), sometimes "...\"...\"", and sometimes '...'.

-- 
Jakub Narebski
Poland
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Received on Tue Sep 26 17:52:16 2006

This archive was generated by hypermail 2.1.8 : 2006-09-26 17:53:07 EST